From a shotgun apartment to a luxe penthouse, the 19-time Grammy winner—and prolific painter—found beauty, fame, and inspiration in New York City